Skip to content

nvme-pci: Re-enable NVME Host Memory Block (HMB) support #6844

Closed
altserg wants to merge 3 commits into
raspberrypi:rpi-6.12.yfrom
altserg:nvme-fix-2
Closed

nvme-pci: Re-enable NVME Host Memory Block (HMB) support #6844
altserg wants to merge 3 commits into
raspberrypi:rpi-6.12.yfrom
altserg:nvme-fix-2

Conversation

@altserg
Copy link
Copy Markdown

@altserg altserg commented May 8, 2025

This pull request restores the NVME Host Memory Block (HMB) support that was disabled in RPi kernel in December 2024.
Instead, the default kernel command line is changed for RPi 4/5 to set maximum allowed HBM size to 0.

This preserves current kernel functionality, but gives the user possibility to manually enable HMB in cmdline.txt file by adding nvme.max_host_mem_size_mb=<size> parameter.

Optionally the user can increase the default CMA size in config.txt by adding/changing the
dtoverlay=vc4-kms-v3d,cma-<size> line

@pelwell
Copy link
Copy Markdown
Contributor

pelwell commented May 9, 2025

This seems reasonable to me. Any concerns, @P33M?

@P33M
Copy link
Copy Markdown
Contributor

P33M commented May 9, 2025

Not really - it's a module parameter so can be defaulted in the driver itself, but doing it this way drops a downstream code patch.

pelwell pushed a commit that referenced this pull request May 9, 2025
@pelwell
Copy link
Copy Markdown
Contributor

pelwell commented May 9, 2025

Lightly squashed, and merged offline. Thanks!

@pelwell pelwell closed this May 9, 2025
pelwell pushed a commit that referenced this pull request May 9, 2025
pelwell pushed a commit that referenced this pull request May 9, 2025
@altserg
Copy link
Copy Markdown
Author

altserg commented May 9, 2025

Is the original HBM disable patch reverted as well ? Changing the .dtsi files only will not have any effect
This patch has to be applied as well for HMB to be usable with custom setting in cmdline.txt:
(b0e1f02)

@pelwell
Copy link
Copy Markdown
Contributor

pelwell commented May 9, 2025

Oh ye of little faith: https://github.com/raspberrypi/linux/commits/rpi-6.12.y/

popcornmix pushed a commit that referenced this pull request May 14, 2025
popcornmix pushed a commit that referenced this pull request May 14, 2025
popcornmix added a commit to raspberrypi/firmware that referenced this pull request May 14, 2025
kernel: arm64: dts: bcm2712-rpi: Add uart0_dma parameter
See: raspberrypi/linux#6838

kernel: configs: Enable SENSORS_POWERZ
See: raspberrypi/linux#6845

kernel: wifi: brcmfmac: Include modinfo for 43456 CLM blob
See: raspberrypi/linux#6843

kernel: nvme-pci: Re-enable NVME Host Memory Block (HMB) support
See: raspberrypi/linux#6844

kernel: pisound-micro: Added pin_pull and pin_b_pull sysfs attributes for Pisound Micro
See: raspberrypi/linux#6848

kernel: drm/rp1/rp1_dpi: Move Composite Sync generation into the kernel
See: raspberrypi/linux#6826

kernel: Fix up rp1_dpi_pio for CONFIG_RP1_PIO=n builds
See: raspberrypi/linux#6851
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this pull request May 14, 2025
kernel: arm64: dts: bcm2712-rpi: Add uart0_dma parameter
See: raspberrypi/linux#6838

kernel: configs: Enable SENSORS_POWERZ
See: raspberrypi/linux#6845

kernel: wifi: brcmfmac: Include modinfo for 43456 CLM blob
See: raspberrypi/linux#6843

kernel: nvme-pci: Re-enable NVME Host Memory Block (HMB) support
See: raspberrypi/linux#6844

kernel: pisound-micro: Added pin_pull and pin_b_pull sysfs attributes for Pisound Micro
See: raspberrypi/linux#6848

kernel: drm/rp1/rp1_dpi: Move Composite Sync generation into the kernel
See: raspberrypi/linux#6826

kernel: Fix up rp1_dpi_pio for CONFIG_RP1_PIO=n builds
See: raspberrypi/linux#6851
popcornmix pushed a commit that referenced this pull request May 20, 2025
popcornmix pushed a commit that referenced this pull request May 20, 2025
popcornmix pushed a commit that referenced this pull request May 23, 2025
popcornmix pushed a commit that referenced this pull request May 27, 2025
popcornmix pushed a commit that referenced this pull request Jun 3, 2025
popcornmix pushed a commit that referenced this pull request Jun 5, 2025
popcornmix pushed a commit that referenced this pull request Jun 5, 2025
popcornmix pushed a commit that referenced this pull request Jun 10, 2025
popcornmix pushed a commit that referenced this pull request Jun 10, 2025
popcornmix pushed a commit that referenced this pull request Jun 23, 2025
popcornmix pushed a commit that referenced this pull request Jun 30, 2025
popcornmix pushed a commit that referenced this pull request Jul 7, 2025
popcornmix pushed a commit that referenced this pull request Jul 11, 2025
popcornmix pushed a commit that referenced this pull request Jul 24, 2025
popcornmix pushed a commit that referenced this pull request Aug 1, 2025
popcornmix pushed a commit that referenced this pull request Aug 19, 2025
popcornmix pushed a commit that referenced this pull request Aug 22, 2025
wangxiaolei12 pushed a commit to wangxiaolei12/linux-yocto-6.1 that referenced this pull request Oct 13, 2025
commit ec6ca8fd21ab010304b6a4b217f0e479f0533ed2 from
https://github.com/raspberrypi/linux.git rpi-6.12.y

Link: raspberrypi/linux#6504
      raspberrypi/linux#6844
Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
wangxiaolei12 pushed a commit to wangxiaolei12/linux-yocto-6.1 that referenced this pull request Oct 14, 2025
commit ec6ca8fd21ab010304b6a4b217f0e479f0533ed2 from
https://github.com/raspberrypi/linux.git rpi-6.12.y

Link: raspberrypi/linux#6504
      raspberrypi/linux#6844
Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
wangxiaolei12 pushed a commit to wangxiaolei12/linux-yocto-6.1 that referenced this pull request Oct 14, 2025
commit ec6ca8fd21ab010304b6a4b217f0e479f0533ed2 from
https://github.com/raspberrypi/linux.git rpi-6.12.y

Link: raspberrypi/linux#6504
      raspberrypi/linux#6844
Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants